Encounter log: radglow bug:

Skunkupine

Well-Known Member
Jun 17, 2023
377
118
My Steele tends to walk away from things that scramble her DNA, so she doesn't give in on the radglow. I assume that reduces the radglow's dominance, but I think somebody forgot a max(0,dominance) in the code, as shown in the Encounter log:


Radglow:
┕ Times Encountered: 1
┕ Dominance: -187 %
 
  • Like
Reactions: Bast

Skunkupine

Well-Known Member
Jun 17, 2023
377
118
Re: Liferoot - confirmed, it now shows up under Medical as "Addiction: Liferoot pollen" and is massively negative for my Steele. Again, looks like a missing check for <= 0. They may have done a check for == 0, which is against the First Commandment Of Floating Point: Thou Shall Not Compare floats for equality, nor for inequality, but only for greater than or equal to or less than or equal to, lest thou be stricken by the evils of Epsilon.
 
  • Like
Reactions: Bast

lowercase_donkey

Scientist
Apr 27, 2016
1,624
232
Re: Liferoot - confirmed, it now shows up under Medical as "Addiction: Liferoot pollen" and is massively negative for my Steele. Again, looks like a missing check for <= 0. They may have done a check for == 0, which is against the First Commandment Of Floating Point: Thou Shall Not Compare floats for equality, nor for inequality, but only for greater than or equal to or less than or equal to, lest thou be stricken by the evils of Epsilon.
It's quite a bit weirder than that. I'm not sure what was intended here, but currently there's a cap of 100 on the high end and no floor. It maybe the floor was -100, or perhaps 0.

Raised the issue with the team, I'm sure I'll hear back soon.

edit: found the original doc, it was intended for 0 to be the floor. I have posted a fix for the team.
 

Elear

New Member
Dec 1, 2023
1
1
Team did not accept my fix for the last patch, but have now done so. Let me know next patch if it's good.
Hey, really sorry to bring this up again, but the liferoot addiction being in the negative still doesn't seem to be fixed to me?

I saw in the changelog for the November 14 update that there was supposed to have been a fix for liferoot and radglow, but my character's stats still show a negative liferoot addiction level. I even tried purposefully encountering liferoots to raise my addiction levels into positive numbers again, but even that didn't help – the liferoot addiction briefly dissappeared when it hit zero, only to reappear as -1% soon after.

Has anyone else reported this still being an issue or am I going insane? I'm playing the browser version if that makes any difference and I triple checked that it's the newest version. I might just be stupid though.
 
  • Like
Reactions: Bast

lowercase_donkey

Scientist
Apr 27, 2016
1,624
232
Hey, really sorry to bring this up again, but the liferoot addiction being in the negative still doesn't seem to be fixed to me?

I saw in the changelog for the November 14 update that there was supposed to have been a fix for liferoot and radglow, but my character's stats still show a negative liferoot addiction level. I even tried purposefully encountering liferoots to raise my addiction levels into positive numbers again, but even that didn't help – the liferoot addiction briefly dissappeared when it hit zero, only to reappear as -1% soon after.

Has anyone else reported this still being an issue or am I going insane? I'm playing the browser version if that makes any difference and I triple checked that it's the newest version. I might just be stupid though.
Thank you for pinging me on this again. You're correct, while one issue was fixed, a second issue in the code was causing what you describe.

Basically it has to do with a strange almost unique way someone was using a function that increases flags (and limits how they grow). I've improved it so it will work better in this case, while also being easier to understand. Ty again for your report.
 

Bast

Well-Known Member
Aug 12, 2021
490
284
Now the Radglow addiction isn't shown in the codex anymore at all. Like it was with Liferoot Pollen before.

Here's a safe file that I made right after the Radglow scene played.
 

Attachments

  • Bicci (M) - 23Hrs 39Mins, 45129 Days - Phaedra_ The Wastes, Vysnovok System.json
    1.1 MB · Views: 1

Jacques00

Administrator
Moderator
Aug 26, 2015
5,140
1,270
Now the Radglow addiction isn't shown in the codex anymore at all. Like it was with Liferoot Pollen before.

Here's a safe file that I made right after the Radglow scene played.
Looking over the flags, it seems that the Radglow influence is displayed as "Dominance" percentage under the Radglow's encounter data, similar to the Venus Pitcher.