Fixed [0.9.140-PUBLIC#6397] New Ewe Leg Logic

[Theron]

New Ewe (SheepTF) has some weird logic when transforming legs.

(t.isTaur() && 0 === rand(4) || t.legCount > 2)

SheepTF leg looks like it's kind of set up to only make Taurs bipeds 25% of the time, but the || LegsCount >2 makes it always return True if Steele is a Taur. The actual change to Sheep Legs has a Taur check that's impossible because of the forced biped TF.

(2 === t.legCount || t.isTaur()) && t.legType !== GLOBAL.TYPE_SHEEP && 0 === rand(4)

This looks like it's supposed to allow Taurs to keep their leg count while transforming them.

Full disclosure: I'd really like if it were possible to be a Sheep-Taur. The game correctly assigns it. The only possible issues are no bespoke description for Sheep (or Goat) lower half, defaulting to equine and maybe the Woolly description. (Which are only awkward.)
Suggestion: Your chest and back are covered in a thick, bushy layer of wool. -> Your torso (If Taur: and barrel) are covered in a thick, bushy layer of wool

...you’ve lost your tauric configuration and are left with a single pair of numerous legs.

The code for actually changing the legs is after the TF message, so it's (rarely) possible for part of the message to act like Steele is still Tauric.

 

[Jacques00]

Hopefully all fixed for the next release.

The order of the leg transformations have been adjusted so the 25% chance to change bipedal or tauric legs into sheep legs is first, then non-bipedal, non-sheep legs will get turned into bipedal. So non-sheep taurs will have the 25% chance of turning sheep, else they turn bipedal--which I think was supposed to be the intention. Instead of having a 25% chance of a 25% chance.

For the appearance screen, goat-taurs were actually assigned as having a "bovid" lower body than an "equine" one, but I separated it out to just "goat" (I assume it was set that way because "goat" sounded too basic). Sheep will now be assigned "sheep".