Fixed [0.9.134-PUBLIC#6197] Medical Milkers and Busty Bulwark don't increase breast size
- Thread starter Hanzo
- Start date
Issue is marked as fixed.
Hopefully fixed for the next release, and hopefully it is a retroactive fix as well.
All implants that affect breast size (Ballistic Breast Liners, Busty Bulwark, Medical Milkers, MedImplants) should now properly add to the size on install and removal. Only MedImplants affect all rows of breasts (and should work on newly-created breast rows while the implant is equipped), whereas the others seem to only affect the top-most row of breasts.
These changes should also make the "Implant-tastic" perk silicone conversion calculations work alongside it as well. If any of the values are misaligned, there should hopefully be a "Fix Size Mod" button that appears in the appearance menu to help correct any out-of-synced calculations. If there are still issues with the sizes or implant in the next release, just uninstall the implants, check if there is a "Fix Size Mod" and choose to fix it, then install a new implant to replace the old one--this should cover all the points of failure related to the bug.
All implants that affect breast size (Ballistic Breast Liners, Busty Bulwark, Medical Milkers, MedImplants) should now properly add to the size on install and removal. Only MedImplants affect all rows of breasts (and should work on newly-created breast rows while the implant is equipped), whereas the others seem to only affect the top-most row of breasts.
These changes should also make the "Implant-tastic" perk silicone conversion calculations work alongside it as well. If any of the values are misaligned, there should hopefully be a "Fix Size Mod" button that appears in the appearance menu to help correct any out-of-synced calculations. If there are still issues with the sizes or implant in the next release, just uninstall the implants, check if there is a "Fix Size Mod" and choose to fix it, then install a new implant to replace the old one--this should cover all the points of failure related to the bug.
Medical Milkers used to affect all rows, but Fenoxo noticed a potential bug and restricted it to the top row. See 0.9.132 Changelog.
Did that potential bug get fixed?
Due to how the Busty Bulwark and Medical Milkers implants apply the cup size bonuses (breasts will be at least a DD-cup, otherwise it's +2 to cup size), the bonus values are unique depending on the current cup size of the breast row, meaning that if each row can be different cup sizes, then the bonus values for each row will need to be recorded in an array to match the row of breasts.
The potential bug comes in where if the two arrays (the implant bonus values and the character's breast rows) are ever misaligned, the removal of the implant may end up subtracting from the wrong breast row. To keep things aligned, extra operations will need to take the implant into consideration for things such as creating a new breast row and removing an existing breast row (so adding and removing the implant's tracking values). I personally think this is manageable, but only under the assumption that the game uses the same create/remove breast row functions for consistency. To avoid any headaches with all the value juggling, I think the ultimate decision was to keep it simple and only let the top row be affected.
In comparison, MedImplants only ever add a flat value of +1 to cup size, so it doesn't need an array to track unique values for any of the rows, so it's easier to manage when it comes to adding/removing rows (though again, assuming the same functions are being used).