[0.9.121-PUBLIC#5667] Weapon Crafting Issues

[Theron]

1. Despite the description, Swords & Staffs don't seem to have an Accuracy bonus.

2. Got an 'Undefined Rigid Dagger': Kirkite, Savicite, Satyrite.

3. It's possible to create Burn and Freeze Chance weapons that don't do Burning/Freezing damage. It is possible to inflict Burn/Freeze, but only to targets with negative Resistance.

4. Savicite adds the Psionically Empowered flag, which increases the weapon's Psionic damage by 5%, according to the in-game description. But there is no way to craft a weapon that does Psionic damage. Savicite adds Kinetic.

5. Satyrite is not consumed when used as the Trick Gem. Instead, it consumes the Gem used in the previous step.

 

[ProtoDot]

Got an "Undefined Polarized Cutlass" with oxonium, picardine, satyrite

 

[Gedan]

Paging @Fenoxo

 

[ProtoDot]

Actually, it seems the accuracy stat just doesn't work in general, regardless if it comes from the base weapon or picardine for resonance

 

[Fenoxo]

Donkey took a pass through last night and recoded how the system is passing things around, which should fix some issues. I'm gonna manually tag in and verify/test each of these with his changes.

1. Will double check.

2. Weird. I thought there might be a chance one of the newer gems had an attribute that wasn't configured properly yet, but the listed gems were all in there from the get-go, and should have descs. Might have been a bungled argument that's fixed now, but I'll test it a few times.

3. This is an interesting one. It was something that occurred to me during creating the system, but I didn't lock it down because it seemed potentially fun (and it would take some more brain effort to fix properly...), and having a flaming sword that sometimes unleashes a trick blast of hyper-cold from the hilt makes the PC seem like a tricky spaceguy with all kinds of cards up his sleeves - ala GotG1 Star-Lord or Jaraxle the rogue.

I'll look over closing it up to avoid confusion.

4. This looks to be an error in the tooltip for PSIONICALLY_EMPOWERED. It's meant to increase Kineticist ability damage when holding the weapon, not the weapon's damage itself. The psionic damage type is a type of lust damage as far as the game's code is concerned, and lust damage weapons are currently not supported by the system.

I've gone ahead and fixed the tooltip data for Psionically Empowered to prevent confusion about this in the future.

5. Just Satyrite tho? Hmmm....

 

[Fullgames]

Fen, I think you misunderstood number 3 in the list there. He didn't mean making a weapon with both freeze and burn specifically, he meant that you can make a weapon with either freeze chance or burn chance with any type of damage but unless it has the respective damage type, it will only apply the status effect on enemies that have negative resistance.

 

[Fenoxo]

1. This persisted through donkey's changes. I think accuracy in general was busted, because while it is described as as accuracy throughout the game, the underlying variable is named "attack". I've gone ahead and contorted the code appropriately.

2. Tough to say with this. I've made a few of these daggers, and they're working, so donkey must have fixed something. Nevermind, reproduced it. I'm on it!

 

[Fenoxo]

Fen, I think you misunderstood number 3 in the list there. He didn't mean making a weapon with both freeze and burn specifically, he meant that you can make a weapon with either freeze chance or burn chance with any type of damage but unless it has the respective damage type, it will only apply the status effect on enemies that have negative resistance.

No I understood, I was just using the most polar opposite example. Fire damage weapon with a freeze chance flag.

 

[Fenoxo]

2. Solved this one. The weapon adjectives table was rolling with the dice size set by the damage adjectives table by accident, making it possible to roll into no data.

 

[Fenoxo]

5. I think donkey must have fixed this one, the satyrite I've been testing with appears to be consumed properly.

 

[Fullgames]

Ah, I see. Maybe you could make it so that when you add an effect that needs specific damage type to work, it adds a little bit of that damage type or make a part of the final weapon damage be of that type. Like if the final damage where to be 30 it would now be 20 of the base and 10 of freeze or burn.

 

[Fenoxo]