[0.8.15] Miscellaneous Bugs

ctenken

Active Member
Feb 4, 2017
41
71
1. window.FluffsnekTalkSleepyCouldBe
— In the [party.oneComp] parser, remove Berwyn. The names are currently misaligned. If you have Atugia, it outputs Ryn's text.

2. window.OliviaFateYes
— [evergreen.dealtWith] parser needs Evergreen and Senja switched.

3. window.OliviaFateNo
— [evergreen.dealtWith] parser needs Evergreen and Senja switched.

4. window.OliviaFateSecondNo
— Change the two instances of evergreen.alive() to !evergreen.dealtWith(), since Evergreen could be replaced by Senja and still be alive.

5. window.OliviaTalkAsgeir
— Change wayfort.hasCorlups() to wayfort.hasCorlups() && !corlup.imprisoned()

6. window.OliviaDogDueCorrect
author("Daliza & Olivia"); author("Farrah & Olivia"); author("Rumie & Olivia");

— Change author() to showName()

7. window.OliviaWayfortIntro
— [wayfort.hasCorlups] Change parser to be [corlup.imprisoned] and switch the order of the text. Otherwise, you can't see the variation where they are imprisoned.
— In the Olivia Wayfort JS file, there are many instances of wayfort.hasCorlups() || corlup.imprisoned() when just wayfort.hasCorlups() would give the same results.

8. window.EvergreenServicesMenu
— For the EvergreenServicesSterility GatedButton, change it to only be available when (pc.isInfertile() && pc.hasVag()) || (pc.isImpotent() && pc.hasRealCock()). If the player doesn't have a vagina, then pc.isInfertile() always returns true, allowing you to repeat the scene over and over.

9. Flag Changes
— flags.TODO_COLOSSEUM Change to flags.COLO_WINS
— flags.TODO_DAL_TALK_HISTORY Change to flags.RQ2_V_DAL1
— flags.TODO_TARAH_TALKED Change to flags.TARAH_STATE
— flags.TODO_TUIQUEST_DONE Change to QUEST_NIGHTMEMORY.isCompleted

10. window.dragonEveGarthBuyWine
"You'd need 600 electrum for that!"
— Change to 900

11. window.UndermountainT5
— All of the var parsers return false. var0 should be flags.KM_COLO, not sure about the other 2.

12. window.LivreaLocalNews
— Can't see 5—7 variations of var0. Push 7 if flags.COLO_WINS, not sure what the requirements are for 5 and 6.

13. window.NottiaWagonApproach
if (comp1 && !comp1.is(brint, brienne)) { comp1.orgasm(); } if (comp2 && !comp2.is(brint, brienne)) { comp2.orgasm(); }
— Change to be Brienne and Kiyoko, instead of Brint and Brienne.

Ryn gets a curious finger traced along her cage before Nottia
— Add a parser for etheryn.isCaged

14. window.KnotCaveTharsusDefeat
]'ll be rendered unto the Master. Under different circumstance, I would gladly experiment on your [party.oneCompanion |your companion |those who came with you ], but it seems that our friend, Tollus, would like to have a word with [party.oneCompanion
— There's a double "your" — "I would gladly experiment on your your companion" OR "I would gladly experiment on your those who came with you"

15. General Parser Change
— Change all [pc.ra] parsers to [pc.race]

16. Undefined Parsers
For some flags that return undefined nothing is output. Some parsers were written as if 0 is the same as being undefined.
Ex:
[flags.NYZE_FUCKED 0 1 3 10 |... have sex. | have sex. |start fucking. |<b>fuck</b>! ]"
If flags.NYZE_FUCKED == undefined then nothing is output when the intention was for the flags.NYZE_FUCKED == 0 variation to be output.

window.NyzeSex:
Add the following at the beginning of the function:
if (flags.NYZE_FUCKED === undefined) { flags.NYZE_FUCKED = 0; }

window.ByverniaFieldEncounter:
Add the following at the beginning of the function:
if (flags.BYVERNIA_FR === undefined) { flags.BYVERNIA_FR = 0; }

window.EvergreenSexBallWorship:
Add the following at the beginning of the function:
if (flags.EVERGREEN_BALLWORSHIP === undefined) { flags.EVERGREEN_BALLWORSHIP = 0; }
 

Libelous

Well-Known Member
Moderator
Aug 2, 2016
634
555
Most of them have been fixed, hopefully to be added to next patch. Thanks.

9. The TODO_TARAH_TALKED has been changed to a var0 check, with it being !!flags.TARAH_STATE because the TARAH_STATE flag can go from 1 to 14.
Same thing with TODO_TUIQUEST_DONE

11. As far as I know, we only visit the Pantheon during Bri Marriage, so I'll leave it as a TODO for now, the other 2 should be fixed

12. Options 5-6 are tied to the Siege of Khor'minos, and while option 5 is tied state 2 (talking to Livernus), I'm not sure on option 6, so I'll leave those two as is for now. Colo_wins option 7 fixed though.

15. I'm fairly certain that pc.ra functions just fine, no reason to change it.
 
Last edited:

ctenken

Active Member
Feb 4, 2017
41
71
Most of them have been fixed, hopefully to be added to next patch. Thanks.

9. The TODO_TARAH_TALKED has been changed to a var0 check, with it being !!flags.TARAH_STATE because the TARAH_STATE flag can go from 1 to 14.
Same thing with TODO_TUIQUEST_DONE

11. As far as I know, we only visit the Pantheon during Bri Marriage, so I'll leave it as a TODO for now, the other 2 should be fixed

12. Options 5-6 are tied to the Siege of Khor'minos, and while option 5 is tied state 2 (talking to Livernus), I'm not sure on option 6, so I'll leave those two as is for now. Colo_wins option 7 fixed though.

15. I'm fairly certain that pc.ra functions just fine, no reason to change it.
9. Thanks for the fixes but it isn't needed to change TODO_TARAH_TALKED to a var0 check. The parser already converts the flag to a boolean.
[flags.TARAH_STATE |flags.TARAH_STATE equals a number and isn't 0 or undefined |flags.TARAH_STATE is 0 or undefined ]
Similarly it isn't needed to use a var0 check with TODO_TUIQUEST_DONE. You can just use the parser QUEST_NIGHTMEMORY.isCompleted.
[QUEST_NIGHTMEMORY.isCompleted |Quest Completed |Quest not started or in progress ]
You can look at where similar parsers are used in the code like [QUEST_MATIHA_REVENGE.isCompleted|

15. Sorry if I wasn't specific enough to which [pc.ra] parsers. The [pc.ra] parser is incorrect if there's no arguments. The parser checks if the pc is a certain race and then outputs a variation.
[pc.ra minotaur cowgirl |cow |sow ]
But sometimes it is used without any arguments which look like they were meant to be [pc.race] parsers.
You are a [pc.ra].
Which outputs:
You are a .

It should be changed to [pc.race]
You are a [pc.race].
Which outputs:
You are a human.
 

Libelous

Well-Known Member
Moderator
Aug 2, 2016
634
555
9. Thanks for the fixes but it isn't needed to change TODO_TARAH_TALKED to a var0 check. The parser already converts the flag to a boolean.
[flags.TARAH_STATE |flags.TARAH_STATE equals a number and isn't 0 or undefined |flags.TARAH_STATE is 0 or undefined ]
Similarly it isn't needed to use a var0 check with TODO_TUIQUEST_DONE. You can just use the parser QUEST_NIGHTMEMORY.isCompleted.
[QUEST_NIGHTMEMORY.isCompleted |Quest Completed |Quest not started or in progress ]
You can look at where similar parsers are used in the code like [QUEST_MATIHA_REVENGE.isCompleted|

15. Sorry if I wasn't specific enough to which [pc.ra] parsers. The [pc.ra] parser is incorrect if there's no arguments. The parser checks if the pc is a certain race and then outputs a variation.
[pc.ra minotaur cowgirl |cow |sow ]
But sometimes it is used without any arguments which look like they were meant to be [pc.race] parsers.
You are a [pc.ra].
Which outputs:
You are a .

It should be changed to [pc.race]
You are a [pc.race].
Which outputs:
You are a human.
Ah I see, thank you for the explanation on the implementation for 9, and the additional information on 15.

I have modified the changes to reflect the ones on 9 and replaced the isolated [pc.ra]'s to [pc.race].

Hopefully that'll solve those problems. Thanks.
 
  • Like
Reactions: ctenken