Version: 0.9.027-PUBLIC-ELECTRON#2710 Bess/Ben title bug

sargentmayhem

Member
Apr 8, 2020
9
0
32
Changing Bess/Ben's non sex Title also changes their Name. As you can see I gave her the original name "Blossom," clicked "Lady Blossom" a few times, and it still lets me call her "Lady Lady Lady Blossom".
Changing their sex Title does not have the same bug.
 

Attachments

  • Bess-Ben title.PNG
    Bess-Ben title.PNG
    134.9 KB · Views: 1

lowercase_donkey

Scientist
Apr 27, 2016
1,613
229
I looked at the code and I don't see an easy way around it.

Code ramble: the non sex title is just setting her name in the data, the same way you can rename frostwyrm. This section is deliberately set up to loop the way you describe: Take their current name, put a word in front of it, and save that combo as their new name:
1669844762876.png
To stop players from being able to loop forever, we could perhaps scan their current name for key words and then disable strings, but that's pretty janky.

I have done some recent work in this area, but it won't help you. I fixed a UI overflow issue where we ran out of buttons if many names were available, and we no longer will force all names to be capitalized.

Edit: the more I think of this the more I wonder if I mucked this up myself a while ago. Here's where things are assigned, and if we stuck to this flags pattern we could recover the ORIGINAL player assigned name as a root, and we wouldn't loop:

1669845095313.png
edit2, no I don't think it was me, looks like we had [bess.name] all the way back in the flash days.
 
Last edited: