I figured out why Converted saves crash on giving Syri the Steele Tech Suit

Beldona

Member
Apr 4, 2022
16
0
37
In converted saves, Syri's inventory.equippedItems["armor"] slot is a 'EmptySlot' class instance which, for whatever reason, does not handle onRemove being called gracefully.

The item slot inventory.equippedItems["armor"] on a fresh save, is an instance of 'PlaceholderArmor'.
This gets replaced by 'FederalGreatcoat' during her quest, but seemingly does not on a converted save, possibly due to the same cause.

I'm unable to determine what the problem is with calling onRemove on EmptySlot, but I suspect there's some handler conflict involved with it.

Something important I noticed:
Simply setting Syri's inventory.equippedItems["armor"] slot to null before attempting to give her the Steele Tech Suit averts the crash.


Seeing as any save that has had the issue before, still seems to have the issue now, and people are still reporting it, I feel a check to see if Syri has EmptySlot equipped when loading a save, should be considered, and if it is, setting it to null directly, to avoid the onRemove bug.

All tests performed on Gecko based browser such as Firefox.

EDIT:
Got it. EmptySlot has no ItemTypeToPropertiesList ID as its item type is 0 which is and empty slot in the array, thus the interpreter recieves undefined when asking what kind of item to replace.
 
Last edited: