[Fixt] Syri suit error 0.69.420-PUBLIC#1732 this.equippedItems[o] is undefined

[Beldona]

Version: 0.69.420-PUBLIC#1732

Message:
this.equippedItems[o] is undefined

Stack:
value@https://www.fenoxo.com/play/TiTS/release/main.662372e7.js:1:5002949
value@https://www.fenoxo.com/play/TiTS/release/main.662372e7.js:1:5003381
u_@https://www.fenoxo.com/play/TiTS/release/content_follower.f15e3515.js:1:10364823
get/<@https://www.fenoxo.com/play/TiTS/release/main.662372e7.js:1:11899578
s@https://www.fenoxo.com/play/TiTS/release/main.662372e7.js:1:10195049

Theory: Syri's follower definition file is importing items from 'item/apparel/[etc]' when it should be '../item/apparel/[etc]' like in other characters' definitions.

EDIT: my bad, I completely forgot to describe. The error occurs when attempting to give Syri the Steele Tech Suit. As soon as the button is clicked.
will add a save when I get back to it.

 

[Fenoxo]

There isn't enough context for this one.

At what point do you get this error? Can you upload a copy of the save to investigate (once you tell me how to trigger the error)?

 

[Beldona]

Hm... Speedran recruiting Syri on a new save and it does not appear to be affected, however my... admittedly long since modified character from pre JS that I had imported is affected. sigh I was hoping not to have to start over once I discovered the save import was actually working.
Oh well. Here's the file anyway. I don't withhold any delusion of this being fixable.

 

[WitchesBrew]

From the reports I've seen, giving Syri a steele suit causes crashes specifically on exported flash saves. Probably a weird bug in the conversion process.

 

[Darkpheonix]

Specifically we get this:

 Version: 0.69.420-BACKER#1731 Message: Cannot read properties of undefined (reading 'onRemove') Stack:
TypeError: Cannot read properties of undefined (reading 'onRemove')
    at o.value (https://www.fenoxo.com/play/TiTS/backer/main.3e16949a.js:1:5002971)
    at o.value (https://www.fenoxo.com/play/TiTS/backer/main.3e16949a.js:1:5003381)
    at Object.u_ (https://www.fenoxo.com/play/TiTS/backer/content_follower.f15e3515.js:1:10364823)
    at https://www.fenoxo.com/play/TiTS/backer/main.3e16949a.js:1:11899578
    at s (https://www.fenoxo.com/play/TiTS/backer/main.3e16949a.js:1:10195049)

 

[Beldona]

I had assumed mine was a separate issue, but I've traced it with breakpoints to the pc.inventory.removeItemByClass line, so it seems like it's the same error even if it's not reporting the same message... maybe because I'm using a variant browser.
The more I look at it the more I think it might be. Not sure how JS reflection chooses its message syntax. I'll just wait for the fix to go live and see if I'm still having the problem.

 

[Fenoxo]

Hey guys, it's likely an issue where an empty slot was configured with the "EmptySlot" item. In flash, that was the data in "empty" slots. In Javascript we use different functionality. Geddy has code that should address that going forward.

Was the above save one of the breaky ones or the new one that worked fine? Because I was able to change her outfit with no problem. If it wasn't one of the broken/crashy ones, please attach one so I can poke at it!

 

[Fenoxo]

(So if it WAS broken, then it should be fixed for next patch)

 

[Beldona]

The above save should have been a broken one.
If the EmptySlot error is corrected, it should resolve a number of similar onRemove errors I've seen pop up for other characters, as they seem to stem from the same source.
Will be excited to see the patch.

 

[Beldona]

I'm assuming the "next patch" will be whatever comes after public 1814.
However, on the off chance that is wrong and the patch was already supposed to be working, I will confirm the bug still seems to be present on saves which already had it.

I will go back to waiting patiently now.

 

[Beldona]

Public 1890, seems fixed!