[0.9.020-BACKER-ELECTRON#2535] Reactive Bust animations not shown on full-size player bust

[Vices]

The reactive bust can show fully animated transformations for things like breast expansion and changes to physique, however due to various bugs these animations are rarely shown in their full glory.

The primary issue is that the full-size player bust never shows animations, only the smaller bust in the top-left corner can actually show such animations. Which means that if the full-size player bust is shown when the change happens the animation is skipped entirely.

The secondary issue is that items like Gush and Magic Milker 7 replace the player bust with an empty or "unknown" bust respectively. If the full-size bust is enabled this actually allows animations because the player bust is moved to the top-left where animations are possible. However when the full-size bust is turned off the bust shown by the item will hide the player bust and thus skip the animation.

I'm impressed by the reactive player bust animations and would love to see it be displayed more prominently by fixing these long-standing issues.

 

[Vices]

Ok, fixed the secondary issue by deleting showBust("") and showBust("MAGIC_MILKER") respectively from the javascript for those items. But that still leaves the primary issue of the animations being skipped on the full-size player bust.

 

[Jacques00]

I'll try to look into this since I'm the one who built it. It could be a quirk of react rendering it for one but not the other. I know it might have something to do with setting keys or id juggling. Not sure yet.

For the items, that's fine. I would rather you just comment them out than fully delete them--just in case the graphics are implemented later, but it's no big deal either way.

 

[Vices]

I'll try to look into this since I'm the one who built it. It could be a quirk of react rendering it for one but not the other. I know it might have something to do with setting keys or id juggling. Not sure yet.

It seems more likely that it's a result of updatePreviousMannequinValues being called too often. I do see it attempting to animate the full-size player bust, but by the time it's actually shown on-screen it has already called updatePreviousMannequinValues again and re-rendered the player bust which skips the animation.

This isn't exclusive to the full-size player bust, it also seems to happen with the mini-bust just less often.

For the items, that's fine. I would rather you just comment them out than fully delete them--just in case the graphics are implemented later, but it's no big deal either way.

Well, for Gush at least it sets the bust to an empty string, so that would probably be a good idea to get rid of. For other cases, perhaps it makes sense to allow items to specifically target the mini-bust? Then the player could still be shown full-size while the item bust is in the top-left corner.

 

[Jacques00]

Can you post a save file with a valid character and those items so I can test with?

 

[Jacques00]

Thanks. Hopefully fixed for the next release (barring any anomalies coming from react itself).

 

[Vices]

Thanks! Really looking forward to the next backer update.